[dvd::rip] PATCH: fix for Perl 5.8.1 project file issue - please test

[Jörn Reder <joern@xxxxxx>]

Hiho,

I put a small patch together which should fix this perl 5.8.1 project 
file issue. Apply it this way:

  % cd Video-DVDRip-0.50.15
  % patch -p0 < dvdrip-perl581bug-patch.txt

I didn't test in-depth, but it should work. Please test it with several
projects, and drop a short message if it works for you (in particular 
switching between titles and subtitles, where available).

You should be able again to open project files saved with older 
versions, and, of course, files saved files with the patched version 
should work, too ;) They should even be readable by older/unpatched 
versions (no matter which Perl version). Also the files are slightly 
smaller now.

If it works for you, I'll release 0.50.16 soon, probably with a few 
other minor fixes which accumulated here.

Regards,

Joern

P.S: just *today* my one week old graphics card thought it would be a 
good idea to prevent my eyes from further damage by just showing me 
permanently black font on black background, resp. generating no signal 
anymore :( So I had to login remotely with X11 from my notebook to my 
workstation, which didn't made debugging easier, but fortunately at 
least possible ;) So I have to mention again: Unix rocks! ;)

-- 
Joern Reder
supporting:   http://www.zyn.de/
unbelievable: http://www.exit1.org/
CPAN:         http://www.perl.com/CPAN/modules/by-authors/id/J/JR/JRED

Index: lib/Video/DVDRip/Project.pm
===================================================================
RCS file: /home/cvsroot/dvdrip/lib/Video/DVDRip/Project.pm,v
retrieving revision 1.41.2.1
diff -u -r1.41.2.1 Project.pm
--- lib/Video/DVDRip/Project.pm 31 Mar 2003 08:54:34 -0000      1.41.2.1
+++ lib/Video/DVDRip/Project.pm 22 Oct 2003 21:06:06 -0000
@@ -166,6 +166,10 @@
        $dd->Purity(1);
        my $data = $dd->Dump;
 
+       my $end_marker = "}, 'Video::DVDRip::Project' );\n";
+       my $end_marker_quoted = quotemeta($end_marker);
+       $data =~ s/$end_marker_quoted.*/$end_marker/so;
+
        $self->set_last_saved_data($last_saved_data);
        $self->set_filename ($filename);
 
@@ -203,7 +207,11 @@
        
        my $fh = FileHandle->new;
        open ($fh, $filename) or croak "can't read $filename";
-       my $data = join ('', <$fh>);
+       my $data;
+       while (<$fh>) {
+               $data .= $_;
+               last if $data =~ /Video::DVDRip::Project/;
+       }
        close $fh;
 
        croak "File is no dvd::rip file"

pgp00038.pgp
Description: PGP signature