[dvd::rip] [PATCH] 0.97.2 NPTL tools missing bug

Hiho,

we have a solution for the various "dvd::rip can't find the tools 
regardless of the NPTL setting" bugs. Thanks to Joe Zbiciak who figured
that out.

dvd::rip 0.97 maintains a cache for the external tools, so the exact 
version numbers are determined only if the corresponding binary on disk
has changed. In conjunction with the NPTL issues that means: the binary
didn't change and so the version number (even if it was "missing") was 
taken from the cache, even if the NPTL setting has changed and the tool
is usable in the meantime.

If you suffer from this bug apply the attached patch:

  % cd Video-DVDRip-0.97.2
  % patch -p0 < dvdrip-0.97.2-missingtools-patch.txt

Another workaround is to delete the dependency cache file after you 
changed your NPTL workaround setting, so dvd::rip is forced to check all
tools again:

  % rm ~/.dvdrip/tool_version_cache

Regards,

Joern

-- 
LINUX - Linux Is Not gnU linuX

Index: lib/Video/DVDRip/Depend.pm
===================================================================
RCS file: /home/cvsroot/dvdrip/lib/Video/DVDRip/Depend.pm,v
retrieving revision 1.9
diff -u -r1.9 Depend.pm
--- lib/Video/DVDRip/Depend.pm  23 Jul 2005 08:14:15 -0000      1.9
+++ lib/Video/DVDRip/Depend.pm  8 Oct 2005 07:14:11 -0000
@@ -395,6 +395,14 @@
                $version = undef;
        }
 
+       #-- Don't cache the version number if the tool
+       #-- is found on the harddrive but cached as
+       #-- missing, otherwise dvd::rip doesn't check
+       #-- tools that crashed due to NPTL issues in
+       #-- the last run but the NPTL settings may have
+       #-- changed in the meantime.
+       $version = undef if -x $path && $version eq 'missing';
+
        return $version;
 }

pgp00005.pgp
Description: PGP signature