Re: [dvd::rip] Patches from the RPMFusion package for Fedora

"Nicolas Chauvet (kwizart)" wrote:

> See some patches attached; I've also few issues I've addressed from
> within the rpm spec file:

Thanks for the patches, I'll take a look at them.

> * # Fix encoding issues:
> Some Files provided in the source archive aren't UTF8
> (Changes Changes.0.46 COPYRIGHT Credits README TODO
> lib/Video/DVDRip/translators.txt)
> It would be nice to have them converted

Mostly no files in the dvd::rip distro are UTF-8 - besides the .po files
(which declare their encoding properly). For now I can't see a reason to
change that.

> * # Remove the included perl modules. The ones
> # installed in the system will be used instead:
> rm -fr perl-modules
> This is really annoying to have internal version used against system
> ones. for the Casual user I understand that having most dependency
> bundled will make things easier. But this will prevent them a lot of
> experience also... IT would really be usefull to have them removed,  as
> this can lead to more problem than it will solve; specially as it will
> prevent bugfixed version to be used from the given distro. (and
> interface is rather stable to use system ones IMO).

The tarballs in the perl-modules/ directory are just shipped for 
convenience, so users not having these modules installed don't need to 
extra download them from CPAN. dvd::rip's Makefile.PL does nothing with
them. dvd::rip works fine if these modules are installed in the system's
Perl library.

> * #Fix for locale
> mkdir -p $RPM_BUILD_ROOT%{_datadir}/locale
> mv $RPM_BUILD_ROOT%{perl_vendorlib}/LocaleData/*
> $RPM_BUILD_ROOT%{_datadir}/locale
> In this case, we need to move the localized data to our system wide (not
> perl specific) directory for localization content. I don't know any perl
> package using the LocaleData directoy against the usual system one,
> moving the files there works just fine.

This directory layout is the default of the Locale::TextDomain module 
used by dvd::rip, so I never thought this could be a problem for someone
;)

> ### Package choices
> 
> * I've choosen to split the dvdrip main package creating the
> dvdrip-master sub-package (that is required by the main package),
> [...]
>
> But when I run dvdrip-master on my C7 server, I have:
> ----------------
> ERROR : dvdrip-multitee isn't found in PATH
> ERROR : dvdrip-progress isn't found in dans PATH
> ERROR : dvdrip-splitpipe isn't found in dans PATH
> ERROR : dvdrip-subpng isn't found in PATH
> ----------------
> Is it possible to have theses check removed? (they aren't needed from
> the master node, IMO).

Yep, that should be possible. I'll consider that for the next release.

> * Default container/codec used.
> I was wondering if I can set as default the use of mkv container using
> dirac for video and flac. This would help to promote quality and free
> (FOSS and patenless) audio/video codecs.
> I haven't done much experiment at this time...
> About the patch for ogm/ogg switch. It seems that nowadays ogv is the
> replacement for at least ogm container. I wonder if it can be switched.

Adding another option (ogv) is probably the best solution, so the user 
can decide.

> * Possible to start encoding from a file (instead of a dvd/vob files)
> [...]

Indeed that would be nice, but with the current design internals not 
easily to do. But still on the wish list...

> * I wonder if dvdrip can be added to Fedora itself. If not all
> dependencies can be added from a fedora only repository, I wonder if we
> can still have it work to submit task to a computer nodes that have more
> or less full featured transcode build.
> Accoridng to my analysis, we would need to start to encode from a file.
> or at least extract file from a non encrypted dvd to have it to work.
> (it couldn't read the content as mpeg2 is patented).
> Then dvdrip could submit (blind) task to the nodes. That would need to
> avoid the check for transcode which is mandatory. xine only could be
> used and mplayer avoided (same as ffmpeg)
> The missing dependencies could be added later.

As well difficult by design. And honestly for me not worth just because
of possible patent issues... :(

> # Website updtate ( freshrpms is now obsoleted)
> As dvdrip is provided from rpmfusion.org for Fedora, could you please
> update the website about the Fedora package installation.

I just updated the page and added your notes (but removed pointers 
regarding copy protection).

Regards,

Jörn

-- 
Think before you code. And while you're coding it won't hurt either. ;)
pgpJywGsYZSrz.pgp
Description: PGP signature