Re: [dvd::rip] 2pass x264 in cluster mode

> Hi guys,
> 
> I've been trying to get dvd::rip to work in cluster mode using 2 pass
> h264.  I'm on suse 11.1 using the latest transcode (1.1) and dvd::rip.
>  It just stops after the first pass with an error statement.  Also
> causes progress to exceed 100% which was posted by someone else too.
> 
> Unfortunately the error messages aren't all that clear but from what I
> can make out the problem lies with dvd::rip attaching -S and -W
> options in cluster mode.  It seems there are some wrong assumptions
> being made regarding the commands being passed to transcode.  Here's
> the culprit I think:
> 
> transcode -H 10 -x vob,null -i
> \/home\/cputter\/dvdrip\-data\/High_Society\/vob\/003\/ -w 921,50 -F
> h264 -f 25.000 -B 36,26,8 -R 1 -y ffmpeg,null -o /dev/null
> --progress_meter 2 --progress_rate 25 && cp x264_2pass.log divx4.log
> -S 00 -W 
> 00001,5,/home/cputter/dvdrip-data/High_Society/tmp/High_Society-003-nav.log
> && echo EXECFLOW_OK
> 
> 
> Obviously dvd::rip isn't expecting "&& cp x264_2pass.log divx4.log" to
> be there since it's trying to pass the -S and -W commands to transcode
> and not to cp.  I'm not all too familiar with transcode and ripping
> and what not but I'm guessing the transcode team recently added the cp
> command to sort out the first pass logs from x264.
> 
> I've tried fixing that myself but can't seem to get it to work since I
> don't know anything about perl  (prefer the elegance of python).  Can
> someone with more experience please have a look.  The only place one
> needs to change this is in Title.pm in the cluster source folder.
> 
> Also the latest source from CVS seems to have removed the 2 pass
> option from ffmpeg's h264 encoding.  Why's that?
> 
> Hope everyone's having a nice day.
> 
> Regards,
> cputter
> 

I can confirm this. I tracked the problem down to the lines 2682 - 2690
in lib/Video/DVDRip/Title.pm and to line 176 in
lib/Video/DVDRip/Cluster/Title.pm, respectively, where (given my limited
familiarity with Perl I might be wrong about this though) the
get_transcode_command from the superior instance is called. It returns a
faulty command due to the lines mentioned. The specific snippet is:

(line 176 and 193,194 in DVDRip/Cluster/Title.pm)
my $command = $self->SUPER::get_transcode_command(no_audio => 1, @_);
[...]
# add -S and -W options for chunk selection
$command .= " -S $psu -W $chunk,$chunk_cnt,$nav_file";

######

(lines 2682 - 2960 in DVDRip/Title.pm)
[...]

if ( $self->tc_video_af6_codec eq 'h264' and
     $self->tc_multipass and $pass == 1 ) {
    $command .= " && cp x264_2pass.log divx4.log";
}

$command = "$command && echo EXECFLOW_OK ";

return $command;
}

It seems to me that this is clearly wrong. The command starting with -S
$psu... is added to $command prior returned from the function although
its last command was the copy action (the echo EXECFLOW_OK gets removed
in the Cluster/Title.pm function). It seems to me that the copy action
should be treated like the echo action (removed and re-added later) in
the get_transcode_command function in DVDRip/Cluster/Title.pm. Sorry for
not providing a patch but I'm not a Perl programmer and I don't want to
break things.

regards,
semkath