jagerhans wrote:
> anyway, since the version test method is weak i'd suggest to mod the
> code so that the program convert is looked for in standard locations,
> first /usr/bin, /usr/local/bin and then if it's found elsewhere dvdrip
> checks to see if it's binary, if i had to do that in bash i'd probably
> do a crude $ file `which convert`| grep ELF || echo 1 . in what file of
> the source tree the check takes place? thanks a lot for the help
I don't like the idea of maintaining hardcoded paths in dvd::rip just to
catch the (in my eyes) esoteric case of workarounding broken ImageMagick
installations. I think it was broken, because convert was not part of
your ImageMagick installation anymore. Every program using ImageMagick's
convert binary couln't work on your system. So it's better to fix the
installation than extending hundreds of apps ;)
Regards,
Jörn
--
LINUX - Linux Is Not gnU linuX
pgp7Pyq3ZaKJF.pgp
Description: PGP signature
|